From 1fa8c6b5ad90d3b902d3da91d3899a49aefc4dda Mon Sep 17 00:00:00 2001 From: Temuulen Ankhbayar Date: Sat, 7 Mar 2026 13:24:38 +0900 Subject: [PATCH] fix: scope ActivationStep validation to current step only The "Continue to Add-ons" button was unresponsive when selecting scheduled activation because validate() ran full-form schema validation (all steps), silently failing on incomplete fields from other steps. Now only checks that a date is selected for scheduled activation. Co-Authored-By: Claude Opus 4.6 --- .../features/services/components/sim/SimConfigureView.tsx | 1 - .../components/sim/configure/steps/ActivationStep.tsx | 5 +++-- .../src/features/services/components/sim/configure/types.ts | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/apps/portal/src/features/services/components/sim/SimConfigureView.tsx b/apps/portal/src/features/services/components/sim/SimConfigureView.tsx index 764a0193..82aec139 100644 --- a/apps/portal/src/features/services/components/sim/SimConfigureView.tsx +++ b/apps/portal/src/features/services/components/sim/SimConfigureView.tsx @@ -79,7 +79,6 @@ function SimConfigureStep(props: Omit & { plan: NonNullable setCurrentStep(3)} onBack={() => setCurrentStep(1)} /> diff --git a/apps/portal/src/features/services/components/sim/configure/steps/ActivationStep.tsx b/apps/portal/src/features/services/components/sim/configure/steps/ActivationStep.tsx index 0c71995e..c223b67a 100644 --- a/apps/portal/src/features/services/components/sim/configure/steps/ActivationStep.tsx +++ b/apps/portal/src/features/services/components/sim/configure/steps/ActivationStep.tsx @@ -13,12 +13,13 @@ export function ActivationStep({ scheduledActivationDate, setScheduledActivationDate, activationFee, - validate, onNext, onBack, }: ActivationStepProps) { const handleContinue = () => { - if (activationType === "Scheduled" && !validate()) { + // Only validate that a date is selected for scheduled activation — + // full-form validation runs at checkout, not mid-wizard. + if (activationType === "Scheduled" && !scheduledActivationDate) { return; } onNext(); diff --git a/apps/portal/src/features/services/components/sim/configure/types.ts b/apps/portal/src/features/services/components/sim/configure/types.ts index 0fd89389..a37856d0 100644 --- a/apps/portal/src/features/services/components/sim/configure/types.ts +++ b/apps/portal/src/features/services/components/sim/configure/types.ts @@ -35,7 +35,6 @@ export interface ActivationStepProps extends BaseStepProps { scheduledActivationDate: string; setScheduledActivationDate: (date: string) => void; activationFee?: ActivationFeeDetails | undefined; - validate: () => boolean; } export interface AddonsStepProps extends BaseStepProps {