ankhbayar/Assist_Design
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Remove Activation_Last_Attempt_At__c field from Salesforce order schema and related utility functions to streamline order data structure. Update buildInClause function to format output with parentheses for improved query syntax.

Browse Source
This commit is contained in:
barsa 2025-10-21 10:19:30 +09:00
parent 8a90003075
commit 7ffd2d562f
6 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/bff/src/integrations/salesforce/utils/order-query-builder.ts
View File

@ -29,7 +29,6 @@ export function buildOrderSelectFields(
"Activation_Scheduled_At__c",
"Activation_Error_Code__c",
"Activation_Error_Message__c",
"Activation_Last_Attempt_At__c",
"ActivatedDate",
"Internet_Plan_Tier__c",
"Installment_Plan__c",
@ -88,4 +87,3 @@ export function buildOrderItemProduct2Fields(
return UNIQUE([...fields, ...additional]);
}

2
apps/bff/src/integrations/salesforce/utils/soql.util.ts
View File

@ -46,5 +46,5 @@ export function buildInClause(values: string[], contextLabel: string): string {
}
});
return sanitized.join(", ");
return `(${sanitized.join(", ")})`;
}

1
packages/domain/orders/providers/salesforce/raw.types.d.ts vendored
View File

@ -30,7 +30,6 @@ export declare const salesforceOrderRecordSchema: z.ZodObject<{
Activation_Scheduled_At__c: z.ZodOptional<z.ZodNullable<z.ZodString>>;
Activation_Error_Code__c: z.ZodOptional<z.ZodNullable<z.ZodString>>;
Activation_Error_Message__c: z.ZodOptional<z.ZodNullable<z.ZodString>>;
Activation_Last_Attempt_At__c: z.ZodOptional<z.ZodNullable<z.ZodString>>;
ActivatedDate: z.ZodOptional<z.ZodNullable<z.ZodString>>;
Internet_Plan_Tier__c: z.ZodOptional<z.ZodNullable<z.ZodString>>;
Installment_Plan__c: z.ZodOptional<z.ZodNullable<z.ZodString>>;

3
packages/domain/orders/providers/salesforce/raw.types.js
View File

@ -30,7 +30,6 @@ exports.salesforceOrderRecordSchema = zod_1.z.object({
Activation_Scheduled_At__c: zod_1.z.string().nullable().optional(),
Activation_Error_Code__c: zod_1.z.string().nullable().optional(),
Activation_Error_Message__c: zod_1.z.string().nullable().optional(),
Activation_Last_Attempt_At__c: zod_1.z.string().nullable().optional(),
ActivatedDate: zod_1.z.string().nullable().optional(),
Internet_Plan_Tier__c: zod_1.z.string().nullable().optional(),
Installment_Plan__c: zod_1.z.string().nullable().optional(),
@ -98,4 +97,4 @@ exports.salesforcePubSubCallbackSchema = zod_1.z.object({
zod_1.z.null(),
]),
});
//# sourceMappingURL=raw.types.js.map
//# sourceMappingURL=raw.types.js.map

1
packages/domain/orders/providers/salesforce/raw.types.ts
View File

@ -50,7 +50,6 @@ export const salesforceOrderRecordSchema = z.object({
Activation_Scheduled_At__c: z.string().nullable().optional(),
Activation_Error_Code__c: z.string().nullable().optional(),
Activation_Error_Message__c: z.string().nullable().optional(),
Activation_Last_Attempt_At__c: z.string().nullable().optional(),
ActivatedDate: z.string().nullable().optional(),
// Internet fields

8
packages/domain/sim/schema.ts
View File

@ -104,6 +104,13 @@ export const simFeaturesUpdateRequestSchema = z.object({
networkType: z.enum(["4G", "5G"]).optional(),
});
export const simReissueRequestSchema = z.object({
newEid: z
.string()
.regex(/^\d{32}$/, "EID must be exactly 32 digits")
.optional(),
});
// ============================================================================
// SIM Order Activation Schemas
// ============================================================================
@ -194,3 +201,4 @@ export type SimPlanChangeRequest = z.infer<typeof simPlanChangeRequestSchema>;
export type SimCancelRequest = z.infer<typeof simCancelRequestSchema>;
export type SimTopUpHistoryRequest = z.infer<typeof simTopUpHistoryRequestSchema>;
export type SimFeaturesUpdateRequest = z.infer<typeof simFeaturesUpdateRequestSchema>;
export type SimReissueRequest = z.infer<typeof simReissueRequestSchema>;