From 9b1e93b7cb096a5ade8965549e10a2324b19ec62 Mon Sep 17 00:00:00 2001
From: barsa <tumurbarsnarantuya@gmail.com>
Date: Thu, 25 Dec 2025 17:30:39 +0900
Subject: [PATCH] Refactor Salesforce Query Logging and Error Handling

- Removed detailed logging of Salesforce query execution to streamline the process.
- Simplified error handling by logging only the error message instead of the full context and SOQL query.
- Enhanced readability and maintainability of the BaseServicesService class by reducing unnecessary log statements.
---
 .../services/base-services.service.ts         | 25 +++----------------
 1 file changed, 4 insertions(+), 21 deletions(-)

diff --git a/apps/bff/src/modules/services/services/base-services.service.ts b/apps/bff/src/modules/services/services/base-services.service.ts
index 31b920e4..28577993 100644
--- a/apps/bff/src/modules/services/services/base-services.service.ts
+++ b/apps/bff/src/modules/services/services/base-services.service.ts
@@ -39,32 +39,15 @@ export class BaseServicesService {
     soql: string,
     context: string
   ): Promise<TRecord[]> {
-    this.logger.debug(`Executing Salesforce query for ${context}`, {
-      soql: soql.replace(/\s+/g, " ").trim(),
-      portalPricebookId: this.portalPriceBookId,
-      portalCategoryField: this.portalCategoryField,
-    });
-
     try {
       const res = (await this.sf.query(soql, {
         label: `services:${context.replace(/\s+/g, "_").toLowerCase()}`,
       })) as SalesforceResponse<TRecord>;
-      const records = res.records ?? [];
-      this.logger.debug(`Query result for ${context}`, {
-        recordCount: records.length,
-        records: records.map(r => ({
-          id: r.Id,
-          name: r.Name,
-          sku: r.StockKeepingUnit,
-          itemClass: r.Item_Class__c,
-          hasPricebookEntries: Boolean(r.PricebookEntries?.records?.length),
-        })),
-      });
-      return records;
+      return res.records ?? [];
     } catch (error: unknown) {
-      const errorMessage = getErrorMessage(error);
-      this.logger.error(`Query failed: ${context} - ${errorMessage}`);
-      this.logger.error(`Failed SOQL: ${soql.replace(/\s+/g, " ").trim()}`);
+      this.logger.error(`Query failed: ${context}`, {
+        error: getErrorMessage(error),
+      });
       return [];
     }
   }