From a6990806103c8be50178ef03f272dbc824041403 Mon Sep 17 00:00:00 2001 From: barsa Date: Mon, 29 Dec 2025 18:41:28 +0900 Subject: [PATCH] Update ESLint Configuration and Clean Up Scripts - Adjusted ESLint configuration to improve clarity in import rules, specifically preventing deep imports from the domain. - Removed unnecessary blank lines in `check-domain-imports.mjs`, `check-exports.mjs`, and `codemod-domain-imports.mjs` scripts for better code cleanliness and maintainability. - Enhanced readability of the import validation message in ESLint configuration. --- eslint.config.mjs | 3 ++- scripts/check-domain-imports.mjs | 2 -- scripts/domain/check-exports.mjs | 2 -- scripts/domain/codemod-domain-imports.mjs | 10 ++++++---- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index 5a9171a6..373631c8 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -230,7 +230,8 @@ export default [ }, { group: ["@customer-portal/domain/*/*", "!@customer-portal/domain/*/providers"], - message: "No deep @customer-portal/domain imports. Use @customer-portal/domain/ only.", + message: + "No deep @customer-portal/domain imports. Use @customer-portal/domain/ only.", }, { group: ["@customer-portal/domain/*/providers/*"], diff --git a/scripts/check-domain-imports.mjs b/scripts/check-domain-imports.mjs index a63805ca..4b4e3e03 100644 --- a/scripts/check-domain-imports.mjs +++ b/scripts/check-domain-imports.mjs @@ -142,5 +142,3 @@ async function main() { } await main(); - - diff --git a/scripts/domain/check-exports.mjs b/scripts/domain/check-exports.mjs index 98dfadd1..586a22f5 100644 --- a/scripts/domain/check-exports.mjs +++ b/scripts/domain/check-exports.mjs @@ -22,5 +22,3 @@ if (wildcardKeys.length > 0) { } console.log("[domain] OK: package.json exports contains no wildcard keys."); - - diff --git a/scripts/domain/codemod-domain-imports.mjs b/scripts/domain/codemod-domain-imports.mjs index 2f96fdd1..79785e9b 100644 --- a/scripts/domain/codemod-domain-imports.mjs +++ b/scripts/domain/codemod-domain-imports.mjs @@ -44,7 +44,9 @@ function replaceCommonProviderTypes(code) { (m, spec) => { const s = String(spec); const needsMove = - s.includes("WhmcsResponse") || s.includes("WhmcsErrorResponse") || s.includes("SalesforceResponse"); + s.includes("WhmcsResponse") || + s.includes("WhmcsErrorResponse") || + s.includes("SalesforceResponse"); if (!needsMove) return m; return `import type {${spec}} from "@customer-portal/domain/common/providers";`; } @@ -54,7 +56,9 @@ function replaceCommonProviderTypes(code) { (m, spec) => { const s = String(spec); const needsMove = - s.includes("WhmcsResponse") || s.includes("WhmcsErrorResponse") || s.includes("SalesforceResponse"); + s.includes("WhmcsResponse") || + s.includes("WhmcsErrorResponse") || + s.includes("SalesforceResponse"); if (!needsMove) return m; return `import type {${spec}} from '@customer-portal/domain/common/providers';`; } @@ -125,5 +129,3 @@ for (const dir of TARGET_DIRS) { } console.log(`codemod-domain-imports: updated ${changedFiles} file(s)`); - -