ankhbayar/Assist_Design
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Update ESLint Configuration and Clean Up Scripts

Browse Source 
- Adjusted ESLint configuration to improve clarity in import rules, specifically preventing deep imports from the domain.
- Removed unnecessary blank lines in `check-domain-imports.mjs`, `check-exports.mjs`, and `codemod-domain-imports.mjs` scripts for better code cleanliness and maintainability.
- Enhanced readability of the import validation message in ESLint configuration.
This commit is contained in:
barsa 2025-12-29 18:41:28 +09:00
parent fd5336f499
commit a699080610
4 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
eslint.config.mjs
View File

@ -230,7 +230,8 @@ export default [
}, },
{ {
group: ["@customer-portal/domain/*/*", "!@customer-portal/domain/*/providers"], group: ["@customer-portal/domain/*/*", "!@customer-portal/domain/*/providers"],
message: "No deep @customer-portal/domain imports. Use @customer-portal/domain/<module> only.", message:
"No deep @customer-portal/domain imports. Use @customer-portal/domain/<module> only.",
}, },
{ {
group: ["@customer-portal/domain/*/providers/*"], group: ["@customer-portal/domain/*/providers/*"],

2
scripts/check-domain-imports.mjs
View File

@ -142,5 +142,3 @@ async function main() {
} }
await main(); await main();

2
scripts/domain/check-exports.mjs
View File

@ -22,5 +22,3 @@ if (wildcardKeys.length > 0) {
} }
console.log("[domain] OK: package.json exports contains no wildcard keys."); console.log("[domain] OK: package.json exports contains no wildcard keys.");

10
scripts/domain/codemod-domain-imports.mjs
View File

@ -44,7 +44,9 @@ function replaceCommonProviderTypes(code) {
(m, spec) => { (m, spec) => {
const s = String(spec); const s = String(spec);
const needsMove = const needsMove =
s.includes("WhmcsResponse") || s.includes("WhmcsErrorResponse") || s.includes("SalesforceResponse"); s.includes("WhmcsResponse") ||
s.includes("WhmcsErrorResponse") ||
s.includes("SalesforceResponse");
if (!needsMove) return m; if (!needsMove) return m;
return `import type {${spec}} from "@customer-portal/domain/common/providers";`; return `import type {${spec}} from "@customer-portal/domain/common/providers";`;
} }
@ -54,7 +56,9 @@ function replaceCommonProviderTypes(code) {
(m, spec) => { (m, spec) => {
const s = String(spec); const s = String(spec);
const needsMove = const needsMove =
s.includes("WhmcsResponse") || s.includes("WhmcsErrorResponse") || s.includes("SalesforceResponse"); s.includes("WhmcsResponse") ||
s.includes("WhmcsErrorResponse") ||
s.includes("SalesforceResponse");
if (!needsMove) return m; if (!needsMove) return m;
return `import type {${spec}} from '@customer-portal/domain/common/providers';`; return `import type {${spec}} from '@customer-portal/domain/common/providers';`;
} }
@ -125,5 +129,3 @@ for (const dir of TARGET_DIRS) {
} }
console.log(`codemod-domain-imports: updated ${changedFiles} file(s)`); console.log(`codemod-domain-imports: updated ${changedFiles} file(s)`);